[buddypress-trac] [BuddyPress Trac] #6002: Use the Group Manage options "new" nav to build the WP Admin Bar current group's edit links

buddypress-trac noreply at wordpress.org
Sun Nov 9 23:58:24 UTC 2014


#6002: Use the Group Manage options "new" nav to build the WP Admin Bar current
group's edit links
-------------------------+------------------
 Reporter:  imath        |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  2.2
Component:  Groups       |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+------------------
Changes (by boonebgorges):

 * keywords:  has-patch 2nd-opinion => has-patch


Comment:

 Big +1 to the idea. A nice improvement. A couple thoughts:

 * Let's go with 'show_in_admin_bar' for the param name. This aligns better
 with core functions (like 'show_in_ui' for `register_post_type()`).
 * Go ahead and set 'show_in_admin_bar' in all cases in
 `bp_core_new_subnav_item()`. Then later we don't have to do `empty` checks
 - just `if ( $menu['show_in_admin_bar'] )`.
 * You're changing the CSS ids. Is this going to cause backward
 compatibility issues with existing themes?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6002#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list