[buddypress-trac] [BuddyPress Trac] #5994: Use bp_core_new_subnav_item() to generate group's manage subnav

buddypress-trac noreply at wordpress.org
Fri Nov 7 09:20:17 UTC 2014


#5994: Use bp_core_new_subnav_item() to generate group's manage subnav
-------------------------+------------------
 Reporter:  imath        |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  2.2
Component:  Groups       |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+------------------

Comment (by imath):

 Replying to [comment:1 boonebgorges]:
 > I might even suggest that if you detect a plugin adding content on the
 `groups_admin_tabs` hook, you throw a `_doing_it_wrong()` notice.
 >
 > Aside from that, patch looks good to me.

 Thanks a lot for your feedback boonebgorges, i've added the
 {{{_doing_it_wrong() }}} notice in case a plugin is directly hooking
 {{{groups_admin_tabs}}}.

 If no objections i'd like to commit this patch as it will be useful for
 the first pass i'm working on about moving avatar management in
 attachments component.

 Once committed, if you think it's necessary, i can write a post on bpdevel
 to inform plugin authors about it.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5994#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list