[buddypress-trac] [BuddyPress Trac] #5983: groups can be created with creator_id = 0

[buddypress-trac]

#5983: groups can be created with creator_id = 0
--------------------------+-----------------
 Reporter:  DJPaul        |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  2.2
Component:  Groups        |    Version:
 Severity:  normal        |   Keywords:
--------------------------+-----------------
 `groups_create_group` will accept a `creator_id` of `0`. This causes
 problems in places where BuddyPress expects the `creator_id` to be set to
 a valid user (i.e. everywhere).

 This was observed in the wild in a unit test,
 `test_total_group_count_groups_accept_membership_request`, which recently
 started failing when tested against WordPress core trunk. I have been
 unable to identify the commits in WP and BP which caused the test to fail.

 https://travis-ci.org/buddypress/BuddyPress/jobs/39704710

 {{{
 There was 1 error:
 1)
 BP_Tests_Groups_Functions::test_total_group_count_groups_accept_membership_request
 Trying to get property of non-object
 /tmp/wordpress/src/wp-content/plugins/BuddyPress/src/bp-groups/bp-groups-
 notifications.php:115
 /tmp/wordpress/src/wp-content/plugins/BuddyPress/src/bp-groups/bp-groups-
 functions.php:1221
 /tmp/wordpress/src/wp-
 content/plugins/BuddyPress/tests/phpunit/testcases/groups/functions.php:107
 /home/travis/.phpenv/versions/5.2.17/bin/phpunit:46
 FAILURES!
 Tests: 666, Assertions: 1101, Errors: 1, Skipped: 9.
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5983>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac