[buddypress-trac] [BuddyPress Trac] #5979: `bp_core_userdata_` cache is unnecessary

[buddypress-trac]

#5979: `bp_core_userdata_` cache is unnecessary
-----------------------------+------------------
 Reporter:  johnjamesjacoby  |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  high             |   Milestone:  2.2
Component:  Members          |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |
-----------------------------+------------------

Comment (by johnjamesjacoby):

 If we don't use `all_with_meta` then we don't get the cache goodness. And
 we do make quite a few calls to `bp_get_user_meta()` that (without access
 to the code at the moment) I assume boil back down to a cached user
 object. I agree that needlessly getting usermeta doesn't make sense, but
 neither does skipping the cache just because we don't need the meta at
 that point.

 It's definitely worth scrutinizing more. I have a hunch the tests will be
 pretty revealing. Thanks for the hint on where to look.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5979#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac