[buddypress-trac] [BuddyPress Trac] #5979: `bp_core_userdata_` cache is unnecessary

[buddypress-trac]

#5979: `bp_core_userdata_` cache is unnecessary
-----------------------------+------------------
 Reporter:  johnjamesjacoby  |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  high             |   Milestone:  2.2
Component:  Members          |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |
-----------------------------+------------------

Comment (by johnjamesjacoby):

 Replying to [comment:4 boonebgorges]:
 > `cache_users()` is only called if we call `fields=all_with_meta`, which
 `BP_User_Query` does not do. But yes, you are correct about `WP_User`.

 Just ran into that. You beat me to the updated patch. I see no reason why
 `BP_User_Query` shouldn't assume `all_with_meta` considering our current
 usages.

 > Would be nice to have a unit test that shows it's cached by WP, and I
 shudder at your ternary syntax, but I'm on board with tearing out our
 redundant caching.

 I'll get test coverage next.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5979#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac