[buddypress-trac] [BuddyPress Trac] #5652: root_blog_id problem since trunk has been "gruntified" for website using trunk version
buddypress-trac
noreply at wordpress.org
Tue May 20 21:03:29 UTC 2014
#5652: root_blog_id problem since trunk has been "gruntified" for website using
trunk version
--------------------------+-----------------------
Reporter: imath | Owner: imath
Type: defect (bug) | Status: reopened
Priority: high | Milestone: 2.1
Component: Core | Version: 2.0
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+-----------------------
Comment (by johnjamesjacoby):
Replying to [comment:6 boonebgorges]:
> > Let's reopen this. Not a fan of having BuddyPress core have hard-
coded references to build or src directories. Those are important to us,
not to millions of other installations. Would like to work towards a more
elegant solution.
> IMHO, some clever solution that manages to do the same thing without
explicitly referencing 'build' or 'src' is bound to be *less* elegant,
because it will rely on some funky string manipulation techniques and will
be harder to understand. The bug is that the string doesn't work with our
build tools, so it seems fine to me if the fix directly addresses the
build tools. If there's a way to fix this that doesn't require jumping
through hoops, that'd be fine, but let's please not waste lots of brain
cycles on what is, in my view, a non-issue.
I didn't say: "let's come up with an overly architected clever solution"
so it's unhelpful to jump to that conclusion. Instead, let's collectively
agree to strictly avoid polluting the core codebase with hardcoded
references to any build processes. (The only exception in my mind here is
minified CSS and JS assets.)
I suspect there's a better way to think of and address this problem. It
looks like it boils down to supporting the activation of BuddyPress living
in somewhat unpredictable locations (subdirectories, mu-plugins maybe,
some other custom plugins directory?) with a custom bootstrap loader. If
that's the case, BuddyPress would currently work on a few different
installations I've seen recently, with non-conventional wp-content
directories or plugin loader/routers.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5652#comment:9>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list