[buddypress-trac] [BuddyPress Trac] #5639: Function screen_icon() is deprecated since wp 3.8.

[buddypress-trac]

#5639: Function screen_icon() is deprecated since wp 3.8.
----------------------------+-----------------------------
 Reporter:  lenasterg       |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  low             |   Milestone:  Future Release
Component:  All Components  |     Version:
 Severity:  minor           |  Resolution:
 Keywords:                  |
----------------------------+-----------------------------
Changes (by boonebgorges):

 * milestone:  Awaiting Review => Future Release


Comment:

 > Do you think it is better to remove it or to replace it with a
 Buddypress speficic function?

 We still support version 3.6+ of WordPress, so I don't think it's wise to
 remove it altogether.

 We could create a BP-specific wrapper function, which would look something
 like this:

 {{{
 function bp_screen_icon() {
     echo bp_get_screen_icon();
 }

 function bp_get_screen_icon() {
     global $wp_version;
     if ( version_compare( $wp_version, '3.8', '<=' ) ) {
         return get_screen_icon();
     }
 }
 }}}

 But, given that the current use of `screen_icon()` doesn't raise any
 deprecated notices, I'm tempted to just leave it as-is, and then remove it
 altogether when we drop support for WP 3.6 and 3.7.

 I'll put this into Future Release. lenasterg, if you or someone else feels
 like writing a patch along the lines of what I've suggested, I suppose
 there's no harm in putting it in. If not, this ticket will serve as a
 reminder to remove the calls to `screen_icon()` after we've dropped
 support for older versions of WP.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5639#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac