[buddypress-trac] [BuddyPress Trac] #5633: Group Administration - Add new members metabox & changing opinion
buddypress-trac
noreply at wordpress.org
Sun May 11 22:29:52 UTC 2014
#5633: Group Administration - Add new members metabox & changing opinion
--------------------------+------------------
Reporter: imath | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.1
Component: Groups | Version: 2.0
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+------------------
Comment (by DJPaul):
Short of re-working all the JS to not have use a hidden field(s), patch
looks OK, but there's some small improvements:
* Use `===` instead of `==`. You might have to typecast `.val()` for this.
* Since you use `$(this)` and `$(e.target)` more than once, you should
store these in variables and use those.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5633#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list