[buddypress-trac] [BuddyPress Trac] #5626: Ending double quote of activity note get mixed with anchor link in Members view

[buddypress-trac]

#5626: Ending double quote of activity note get mixed with anchor link in Members
view
--------------------------+---------------------------
 Reporter:  nirgalo       |       Owner:  boonebgorges
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  2.1
Component:  Members       |     Version:  2.0
 Severity:  normal        |  Resolution:  fixed
 Keywords:                |
--------------------------+---------------------------
Changes (by boonebgorges):

 * owner:   => boonebgorges
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"8400"]:
 {{{
 #!CommitTicketReference repository="" revision="8400"
 Standardize placement of 'bp_get_activity_latest_update_excerpt' filter

 When latest activity update excerpts are displayed in the Members
 directory,
 they are displayed like this:

   - "Foo"

 instead of just

   Foo

 The wrapped string is then sent through the
 'bp_get_activity_latest_update_excerpt'
 filter. However, this creates inconsistencies with other uses of the
 filter, which only filter the excerpt itself - not the dash and quotes.
 This
 changeset fixes the inconsistency.

 In addition, certain translations of the wrapper string were removing an
 erroneous space character from the original string, which had been
 preventing
 the make_clickable() callback from appending the trailing quote to URLs
 that
 appeared at the end of the activity excerpt. In these translations (such
 as
 fr_FR), the result was that the improper filter placement described above
 was
 causing trailing quotation marks to be included as part of URLs when they
 appeared at the end of an update string (from the point of view of
 make_clickable()).
 This changeset also removes this extra space, since the bug will no longer
 manifest itself in any language.

 Fixes #5626
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5626#comment:16>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac