[buddypress-trac] [BuddyPress Trac] #3430: Groups Members - add Order by: Group Activity

[buddypress-trac]

#3430: Groups Members - add Order by: Group Activity
---------------------------+----------------------
 Reporter:  slaFFik        |       Owner:  slaFFik
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  2.1
Component:  Groups         |     Version:  1.5
 Severity:  normal         |  Resolution:
 Keywords:  needs-refresh  |
---------------------------+----------------------
Changes (by boonebgorges):

 * keywords:  has-patch needs-unit-tests => needs-refresh


Comment:

 Hi imath -

 Don't worry about the caching for now. I just meant that having it broken
 out into a separate methed will make it easier to cache in the future.

 Unit test is on the right track, but it looks to me like the
 'group_activity' sort type will result in the same order as
 'last_updated', so we can't necessarily depend on the results of the test.
 I suggest the following: create 3 users with consecutive 'date_modified'
 dates. Then create three pieces of activity and order it so that the
 results of the 'group_activity' ordering should be `array( $u2, $u1, $u3
 )` (or something that definitely could not arise by accident). It might
 make sense not to use the 'joined_group' activity item for this reason -
 you could really just use 'foo', since it shouldn't matter from the
 query's point of view :)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3430#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac