[buddypress-trac] [BuddyPress Trac] #5626: Ending double quote of note get mixed with anchor link in Activity view

[buddypress-trac]

#5626: Ending double quote of note get mixed with anchor link in Activity view
--------------------------+-----------------------------
 Reporter:  nirgalo       |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Activity      |    Version:  2.0
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 (original issue discussion here: http://buddypress.org/support/topic/bug-
 with-links-posts-in-activity-page/ )

 1. go to the Activity page, post a new note such as the following:
 here is the link : http://google.com
 2. go to the Members page, look at the note you just posted : it appears
 in between double quotes
 3. from this Members page, click on the link inside the note

 '''Expected result''': new page opens with the link

 '''Actual result''': new page opens but the link doesn’t load, because the
 ending double quote is part of the link (http://google.com“)

 '''Analysis''': the issue seems to originate from this code in
 bp_get_member_latest_update() (bp-members-template.php):

 {{{
 $update_content = apply_filters( 'bp_get_activity_latest_update_excerpt',
 sprintf( _x( '- "%s "', 'member latest update in member
 directory', 'buddypress' ), trim( strip_tags( bp_create_excerpt(
 $update['content'], $length ) ) ) ) );
 }}}

 When "{{{"}}} and {{{%s}}}" are joined in the form "{{{"%s}}}",
 the straight double quotes get transformed into fancy double quotes (not
 sure which area of code is responsible for this transformation), and the
 closing double quote is being appended to the link itself. Adding a space
 in between "{{{"}}}" and "{{{%s}}}" in order to get "{{{" %s}}}"
 fixes the problem, quotes are not transformed, and link is proper (but the
 visual aspect is not fancy).

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5626>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac