[buddypress-trac] [BuddyPress Trac] #5557: BP_Group_Extension settings_screen_save

buddypress-trac noreply at wordpress.org
Thu May 1 23:06:09 UTC 2014

#5557: BP_Group_Extension settings_screen_save
 Reporter:  dcavins      |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  low          |   Milestone:  2.1
Component:  Groups       |     Version:
 Severity:  minor        |  Resolution:
 Keywords:  needs-patch  |

Comment (by boonebgorges):

 > that redirect will also be fired when saving from the WordPress group
 admin interface, which is not ideal, since it usually redirects the user
 to the group's front-end admin screen

 Yes, but under the hood, BP knows whether you're in edit vs admin mode,
 even if you use the generic `settings_screen_save()`. I don't see a
 serious problem here (though I'd have to look more closely to see how it'd
 work best).

 > And I imagine that if it occurs before some other piece is saved, there
 could be conflicts and lost data.

 This seems a bit more worrisome. During group creation and group editing,
 it should not be an issue, since the only data displayed on the screen is
 related to the current group tab. On group admin, it's more complex,
 because many items are sent over the same POST request. It probably will
 *not* make sense to do the redirect when in the Dashboard (I think BP does
 it anyway).

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5557#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list