[buddypress-trac] [BuddyPress Trac] #5603: Posting a new Activity causes activity-loop.php scope filters to be removed

buddypress-trac noreply at wordpress.org
Thu May 1 10:59:34 UTC 2014


#5603: Posting a new Activity causes activity-loop.php scope filters to be removed
-------------------------------------------------+-------------------------
 Reporter:  xyhavoc                              |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  Activity                             |  Review
 Severity:  major                                |     Version:  2.0
 Keywords:  reporter-feedback has-patch 2nd-     |  Resolution:
  opinion                                        |
-------------------------------------------------+-------------------------

Comment (by boonebgorges):

 > I chose not to enable heartbeat when on a user's profile because i
 thought it doesn't make sense to surcharge this part as to be usable it
 would require the user to open a new browser and post from this browser to
 see on the first browser that he posted a new activity.

 Yes, I think this original decision was a good one, and I don't think we
 should change it (definitely not for 2.0.1).

 > In bp-templates/bp-legacy/buddypress/buddypress-functions.php at line
 714

 What's the natural situation where this will happen? When *should*
 `$last_recorded = 0`? When an activity stream is empty? (Just trying to be
 clear on why we'd try to preserve this `else` condition.)

 5603.02.patch looks fine to me, in any case.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5603#comment:11>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list