[buddypress-trac] [BuddyPress Trac] #5494: BP 2.0 beta - Groups Avatars - Notice appears when Avatars are turned off

[buddypress-trac]

#5494: BP 2.0 beta - Groups Avatars - Notice appears when Avatars are turned off
--------------------------+-----------------------------
 Reporter:  shanebp       |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Groups        |    Version:
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 [ When creating a ticket, 'Version' does not include an option for 2.0 ]

 If Settings > Discussion > Avatar Display is not selected, then this
 notice appears wherever a Group Avatar (default or otherwise) is called:

 {{{
 Notice: Undefined property: stdClass::$avatar_thumb
 in /.../wp-content/plugins/buddypress/bp-groups/bp-groups-template.php
 on line 526
 }}}

 And an empty rectangle is shown, with an empty img src.

 If a Group has an avatar, and then Avatar Display is turned off, then the
 Notice does not appear, but the empty rectangle is shown.

 So maybe the issue lies in the backpat in bp_get_group_avatar() ?

 [I don't see 'avatar_thumb' in BP_Groups_Template, at least as called by
 bp_has_groups() but I've missed the obvious before. ]

 Related... ?
 When avatars are turned off, the Notice does not appear for Members (
 Group or otherwise ).
 But in the Group Members screen, the area where the member avatar would
 appear is still there, so the member's name is pushed down.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5494>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac