[buddypress-trac] [BuddyPress Trac] #5130: Synchronizing activity comments to main component

[buddypress-trac]

#5130: Synchronizing activity comments to main component
-------------------------+-----------------------
 Reporter:  r-a-y        |       Owner:  r-a-y
     Type:  enhancement  |      Status:  assigned
 Priority:  normal       |   Milestone:  2.0
Component:  Core         |     Version:  1.2
 Severity:  normal       |  Resolution:
 Keywords:               |
-------------------------+-----------------------

Comment (by r-a-y):

 rogercoathup - The issue was trashing a post, which in 04.patch, deleted
 all comments tied to an activity item.

 `05.patch` solves this.

 In particular, the changes are:

 - `bp_blogs_catch_transition_post_status()` now only deletes the blog
 post's activity item (and therefore any activity children automatically).
 It doesn't use `bp_blogs_remove_post()` since that function already runs
 on the `'record_post'` hook.  Post comments are left intact.

 - `bp_blogs_remove_activity_meta_for_trashed_comments()` is new and
 deletes the associated comment meta key since the activity item no longer
 exists when trashed.

 - `bp_blogs_sync_delete_post_comments_on_post_delete()` is now removed
 since I've addressed the post status transition change.

 Let me know what you think.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5130#comment:34>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac