[buddypress-trac] [BuddyPress Trac] #5130: Synchronizing activity comments to main component

[buddypress-trac]

#5130: Synchronizing activity comments to main component
-------------------------+-----------------------
 Reporter:  r-a-y        |       Owner:  r-a-y
     Type:  enhancement  |      Status:  assigned
 Priority:  normal       |   Milestone:  2.0
Component:  Core         |     Version:  1.2
 Severity:  normal       |  Resolution:
 Keywords:               |
-------------------------+-----------------------

Comment (by r-a-y):

 > To be honest, I'm still not clear on why we'd want this to be true, but
 I think your solution is fine for 2.0. Shouldn't we also be doing
 something in bp_blogs_sync_delete_post_comments_on_post_delete()? You have
 a $force_delete param but I can't see where it'd ever be used (you're
 hooked to 'bp_blogs_before_remove_post'.

 Sorry, forgot to remove that part of the code from the patch.  Was
 experimenting with trash / untrash post status changes in
 `bp_blogs_transition_activity_status()` and how that handles comments and
 activity items related to comments.

 There are too many things required to get this working for 2.0-beta, so I
 decided to hold off.

 At the moment, it is easier to delete all associated comments when a post
 is trashed than worrying about re-recording the activity stream items in
 their rightful slot for post comments when a post is untrashed.  Let me
 know if this is a dealbreaker.

 I'll work on some unit tests as well.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5130#comment:31>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac