[buddypress-trac] [BuddyPress Trac] #5130: Synchronizing activity comments to main component

[buddypress-trac]

#5130: Synchronizing activity comments to main component
-------------------------+-----------------------
 Reporter:  r-a-y        |       Owner:  r-a-y
     Type:  enhancement  |      Status:  assigned
 Priority:  normal       |   Milestone:  2.0
Component:  Core         |     Version:  1.2
 Severity:  normal       |  Resolution:
 Keywords:               |
-------------------------+-----------------------

Comment (by boonebgorges):

 Thanks for your quick turnaround on this, r-a-y.

 > Mirroring of close comments / threaded comment depth options to
 blogmeta.

 Brilliant. This alleviates all my worries about overhead in blog loops.
 Thanks for this.

 > I have commented out the part of the code in question, which relies on a
 check on the actual post type. We currently don't mirror the post type in
 activity meta at the moment, so we can't do such a check.

 Let's not worry about it at the moment. We only natively support 'post'
 for new_blog_post activity types anyway. When we implement CPT mirroring
 at some point (#3460) we can deal with it.

 > bp_blogs_remove_associated_blog_comments() now supports a $force_delete
 argument. If this is false, the comments are trashed instead of deleted.

 To be honest, I'm still not clear on why we'd want this to be true, but I
 think your solution is fine for 2.0. Shouldn't we also be doing something
 in `bp_blogs_sync_delete_post_comments_on_post_delete()`? You have a
 `$force_delete` param but I can't see where it'd ever be used (you're
 hooked to `'bp_blogs_before_remove_post'`.

 Once this last bit is cleared up, I think we're good to go for 2.0. Thanks
 again.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5130#comment:29>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac