[buddypress-trac] [BuddyPress Trac] #5479: Messages: Better notification formatting and marking

[buddypress-trac]

#5479: Messages: Better notification formatting and marking
-------------------------+------------------
 Reporter:  r-a-y        |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  2.0
Component:  Messaging    |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+------------------

Comment (by boonebgorges):

 Is there a reason you're doing this

 {{{
 $text = sprintf( __( '%2$s sent you a new private message', 'buddypress'
 ), (int) $total_items, bp_core_get_user_displayname( $secondary_item_id )
 );
 }}}

 instead of this

 {{{
 $text = sprintf( __( '%1$s sent you a new private message', 'buddypress'
 ), bp_core_get_user_displayname( $secondary_item_id ) );
 }}}

 ?

 I assume it's just a half-finished idea :)

 `bp_messages_screen_inbox_mark_notifications()` should be properly
 deprecated if you're going to use a different technique for clearing.

 A unit test for the failed cache busting would be truly delightful, but is
 not a deal-breaker.

 Otherwise the changes look good. Thanks!

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5479#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac