[buddypress-trac] [BuddyPress Trac] #3460: Support custom post types in activity stream

[buddypress-trac]

#3460: Support custom post types in activity stream
-------------------------------------------------+-------------------------
 Reporter:  boonebgorges                         |       Owner:
     Type:  enhancement                          |  boonebgorges
 Priority:  low                                  |      Status:  new
Component:  Activity                             |   Milestone:  Future
 Severity:  normal                               |  Release
 Keywords:  2nd-opinion has-patch needs-testing  |     Version:  1.2.8
                                                 |  Resolution:
-------------------------------------------------+-------------------------

Comment (by boonebgorges):

 Thanks for the work here, imath. I've finally started to take a close look
 at it.

 The underlying technical architecture (where you register the
 activity_actions dynamically, based on labels->singular_name) looks good
 to me.

 I am concerned about the workflow. I'm finding it to be a bit complex in
 some ways, and a bit incomplete in others, especially surrounding
 subsites. Some thoughts:

 - If I understand correctly, settings for a given post type are shared
 across sites. Say I'm running a plugin that registers post type 'foo' on a
 couple of subsites. If I want to record 'foo' on one subsite but not on
 another, then I'm out of luck, right? (aside from changing privacy
 settings)
 - In the same vein, it appears that a post type (say, Pages) that is
 marked as "tracked" in the global BP settings cannot be disabled on
 subsites. If this is going to be the case, then it should be reflected in
 the interface. However, I think it probably should *not* necessarily be
 the case - it seems like a very common use case to want to track a post
 type on the root blog but not the same post type on a secondary blogs.
 - The interaction of privacy settings and trackability on subsites is a
 bit confusing. As it stands, it looks like setting blog_public = 0 is
 enough to disable all tracking for the site. But if this is the case, then
 the interface should enforce it and/or provide documentation. So, eg, the
 whole checkbox section should be disabled or hidden when the blog is not
 public.
 - At the same time, if we're going to start allowing fine-grained, per-
 post-type user settings for blog tracking, maybe we should be doing away
 with the blog_public bit - or at least, we would only use blog_public = 0
 to provide default tracking settings (unchecked)

 Again, I'm not 100% sure which way to go with any of these questions, but
 all of them need some work and some discussion.

 As for the milestone, I think that we are too late to complete this
 ticket, as currently conceived, for BP 2.0. I do think that the root-blog
 stuff is good, however, so there may still be time to do a partial fix.
 That would mean removing all parts of this patch that are specific to
 subsites, and introducing support only for CPTs on the root blog for 2.0.
 This would be a more modest new feature, but it is much simpler from a UX
 point of view, and it might give us a chance to put the meat of the patch
 through its paces while we work on the subsite stuff for 2.1. Does this
 seem worth it?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3460#comment:70>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac