[buddypress-trac] [BuddyPress Trac] #5130: Synchronizing activity comments to main component

[buddypress-trac]

#5130: Synchronizing activity comments to main component
-------------------------+--------------------
 Reporter:  r-a-y        |       Owner:  r-a-y
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  2.0
Component:  Core         |     Version:  1.2
 Severity:  normal       |  Resolution:
 Keywords:               |
-------------------------+--------------------

Comment (by boonebgorges):

 Looking great, r-a-y.

 > Perhaps we should look into caching the blog's threaded depth and the
 post's comment status options ourselves instead of using the singleton-
 stuffing method in this patch.

 I'd suggest mirroring it in blogmeta. Then it'll be autoslurped in
 activity loops with https://buddypress.trac.wordpress.org/browser/trunk
 /bp-blogs/bp-blogs-activity.php#L214

 > If different blogs have different threaded depths, this will not make
 for a consistent appearance in the activity stream. The question is
 whether we should even adopt WP's threaded depth setting?

 Groan, this is a lose-lose. I'd suggest looking at the subblog's comment
 depth setting and the main blog's comment depth settings (assuming #2768;
 if not, just hardcode a sensible number like 5), and then choosing the
 lesser of the two when deciding whether to allow activity commenting.

 > If WP's threaded comments are later disabled, WP's comments are
 displayed flat. However, BP's activity stream does not change. If we
 wanted to mirror this, we'd need to rebuild the activity comment tree for
 each corresponding blog post. Not very great.

 This seems like such a harmless edge case that I'd suggest forgetting that
 you ever thought of it :)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5130#comment:17>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac