[buddypress-trac] [BuddyPress Trac] #5220: Overhaul implementation of xprofile field types

[buddypress-trac]

#5220: Overhaul implementation of xprofile field types
------------------------------------------+-----------------------
 Reporter:  DJPaul                        |       Owner:  DJPaul
     Type:  enhancement                   |      Status:  assigned
 Priority:  normal                        |   Milestone:  2.0
Component:  XProfile                      |     Version:
 Severity:  normal                        |  Resolution:
 Keywords:  has-patch dev-feedback early  |
------------------------------------------+-----------------------

Comment (by DJPaul):

 Thanks Ray. Great to have a third great review and different/valid
 feedback, too. I'll get to look at this hopefully this week sometime, and
 get the fixes onto Github once I've dived into those original units. It's
 a bummer that the unit tests didn't reveal the problem. Perhaps Boone can
 lend his experience here and help us get a failing test before we fix it.

 > In my mind, we should move most of the logic from
 xprofile_set_field_data() to BP_XProfile_ProfileData::save()

 We can look into this in the future, or at least after this ticket gets
 committed/closed. :)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5220#comment:24>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac