[buddypress-trac] [BuddyPress Trac] #5399: Review metadata functions for irregularities

[buddypress-trac]

#5399: Review metadata functions for irregularities
--------------------------+---------------------------
 Reporter:  boonebgorges  |       Owner:  boonebgorges
     Type:  enhancement   |      Status:  assigned
 Priority:  normal        |   Milestone:  2.0
Component:  Core          |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  2nd-opinion   |
--------------------------+---------------------------

Comment (by boonebgorges):

 In [changeset:"8129"]:
 {{{
 #!CommitTicketReference repository="" revision="8129"
 Don't improperly sanitize meta_key in _meta() functions

 Many BP meta functions have always stripped certain characters from the
 $meta_key parameter before performing their operations. This is a terrible
 idea
 on a number of levels: it doesn't provide any feedback to the user, it
 silently
 performs actions that are not equivalent to the ones intended by the user,
 and
 it doesn't serve any real purpose (since any necessary sanitization
 happens at
 the level of $wpdb). Moreover, it wasn't even applied consistently across
 all
 functions. A truly delightful grab bag.

 This changeset removes the sanitization, and updates the necessary unit
 tests
 to reflect the change.

 See #5399
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5399#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac