[buddypress-trac] [BuddyPress Trac] #5399: Review metadata functions for irregularities

[buddypress-trac]

#5399: Review metadata functions for irregularities
--------------------------+---------------------------
 Reporter:  boonebgorges  |       Owner:  boonebgorges
     Type:  enhancement   |      Status:  assigned
 Priority:  normal        |   Milestone:  2.0
Component:  Core          |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  2nd-opinion   |
--------------------------+---------------------------

Comment (by r-a-y):

 __A1 - Meta key sanitization removal__

 It's a little weird for devs to be using characeters outside
 `[^a-zA-Z0-9_]` for their meta keys, but yeah, let WP handle meta keys.

 __A2 - Meta value trimming on deletion__
 __B1, B2 - Strict type checking when fetching meta__

 No complaints here.

 __B3 - Getting meta with no meta key__

 > For bp_activity_get_meta(), the return value is at least structured in a
 way where someone might use it.  However, I think that the chance of
 breakage is fairly slight, and we can publicize it prior to release. I
 recommend that we move to the BP return format.

 So to confirm, you want to move to the WP format or the BP format?
 Regardless, I'm fine with either option.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5399#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac