[buddypress-trac] [BuddyPress Trac] #5241: Notices occur when BP_ENABLE_ROOT_PROFILES is enabled

[buddypress-trac]

#5241: Notices occur when BP_ENABLE_ROOT_PROFILES is enabled
--------------------------+-----------------------
 Reporter:  henrywright   |       Owner:
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  2.0
Component:  Core          |     Version:  1.7
 Severity:  minor         |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------
Changes (by r-a-y):

 * keywords:   => has-patch
 * component:  Rewrite Rules => Core


Comment:

 While looking into another ticket, I came across this bug again.

 Thought I might as well patch this since rewrite rules isn't going to be
 implemented until the next release cycle.

 Attached patch:

 - Removes the query to look up the page based on the BP page offset
 - Resets the post with `bp_theme_compat_reset_post()` since it's a great
 function to add a dummy post
 - Sets the theme compat flag to false since bp_theme_compat_reset_post()
 sets that flag to true
 - Tweaks the `locate_template()` call so it is only run when
 `bp_use_theme_compat_with_current_theme()` is false.  This should probably
 be moved to a separate commit altogether, but thought I'd throw it in here
 since I was touching `bp_core_load_template()`!

 Notices when root profiles is enabled should disappear now.  I've tested
 this in various scenarios and it works.  Also passes the existing root
 profile unit tests.

 Feedback appreciated.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5241#comment:13>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac