[buddypress-trac] [BuddyPress Trac] #5454: BuddyPress Groups should gracefully handle the case where show_avatars is false

buddypress-trac noreply at wordpress.org
Tue Mar 11 14:01:26 UTC 2014


#5454: BuddyPress Groups should gracefully handle the case where show_avatars is
false
-------------------------------------+------------------------------
 Reporter:  jjeaton                  |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Avatars                  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------------------
Changes (by jjeaton):

 * keywords:   => has-patch needs-testing


Comment:

 It seems the issue here is the backwards compat. that
 `bp_get_group_avatar` uses if the avatar doesn't exist. I've created a
 patch that only uses the backwards compat. code if that property exists on
 the group object, otherwise it returns nothing just like members do. This
 fixes the issue for me.

 We could also have this display the BuddyPress default avatar, but since
 members is already doing it this way, I assume that's the recommended
 approach.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5454#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list