[buddypress-trac] [BuddyPress Trac] #4265: WP 3.4/BP1.5.6 – issue with quotes on SWA

[buddypress-trac]

#4265: WP 3.4/BP1.5.6 – issue with quotes on SWA
-----------------------------------+------------------
 Reporter:  chouf1                 |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  2.0
Component:  Activity               |     Version:  1.7
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+------------------
Changes (by boonebgorges):

 * keywords:  has-patch 2nd-opinion needs-unit-tests => has-patch 2nd-
               opinion


Comment:

 I messed around for a while trying to write unit tests, but it's not
 really practical. (wptexturize() loads all the replacement texts into a
 static variable on the first load, before the test would have access to
 filter 'gettext'.)

 I did manage to reproduce the issue, and I can confirm that slashes appear
 to be the issue. When our content comes from the db and looks like this:
 `Here are some \"quotes\"`, wptexturize() first inserts a space to make \"
 quotes \" and then interprets the quotes to belong to the slashes - thus
 the incorrect direction on the first one.

 My gut feeling is that, instead of backing up wptexturize, we should be
 running stripslashes_deep() earlier, since the root of the problem is BP's
 perennial double-escaping. Does anyone see an issue with moving our
 'stripslashes_deep' filters back to priority 9, or even earlier?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4265#comment:12>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac