[buddypress-trac] [BuddyPress Trac] #5411: Members nav of single group : total members seems not set

[buddypress-trac]

#5411: Members nav of single group : total members seems not set
------------------------------+---------------------------
 Reporter:  imath             |       Owner:  boonebgorges
     Type:  defect (bug)      |      Status:  reopened
 Priority:  normal            |   Milestone:  2.0
Component:  Groups            |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+---------------------------

Comment (by boonebgorges):

 Hi r-a-y - That patch seems fine. In my mind, I guess I'd been thinking
 something more along the lines of:

 `if ( empty( $group->admins ) ) {
     $group = groups_get_group( array(
         'group_id' => $group->id,
         'populate_extras' => true,
     ) );
 }`

 This prevents us from having to examine arguments for original intent, and
 also keeps all the query logic centralized in the BP_Groups_Group class.
 But it's a fairly small difference from what you're doing (and anyway, it
 should rarely be triggered) so whatever you think is best is OK with me.

 Thanks for doing this!

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5411#comment:20>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac