[buddypress-trac] [BuddyPress Trac] #5411: Members nav of single group : total members seems not set

[buddypress-trac]

#5411: Members nav of single group : total members seems not set
------------------------------+---------------------------
 Reporter:  imath             |       Owner:  boonebgorges
     Type:  defect (bug)      |      Status:  reopened
 Priority:  normal            |   Milestone:  2.0
Component:  Groups            |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+---------------------------

Comment (by r-a-y):

 > I'd guess that your suggestion for bp_group_list_admins() is going to be
 good enough for most purposes; hopefully not many people are attempting to
 access that part of the global directly.

 We can definitely do that.

 However, the issue with BP Group Hierarchy is it already uses
 [https://github.com/ddean4040/BP-Group-Hierarchy/blob/master/bp-group-
 hierarchy-classes.php#L26 two arguments] in its constructor class.
 However, `BP_Groups_Group` just added a second parameter (r7898), so that
 causes some issues that could only be solved if ddean added a third
 parameter to his constructor or just ignores the `populate_extras`
 parameter and pastes all the extra group data calls into his
 `BP_Groups_Hierarchy::populate()` method.

 There might be other ways to solve the issue, but that's what I gathered
 from my quick audit of BP Group Hierarchy.

 > Off topic, but what are the aspects of bp-group-hierarchy that are
 broken by the groupmeta changes?

 BP Group Hierarchy copies most of the `BP_Groups_Component` class.
 Because of that, ddean will need to copy in the changes to add the
 `meta_tables` parameter from
 [https://buddypress.trac.wordpress.org/changeset/7840/trunk/bp-groups/bp-
 groups-loader.php r7840] since it won't be there in the
 [https://github.com/ddean4040/BP-Group-Hierarchy/blob/master/bp-group-
 hierarchy-loader.php#L63 current version of his plugin].

 It's a simple fix.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5411#comment:15>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac