[buddypress-trac] [BuddyPress Trac] #5440: Add pagination to group membership requests admin page

buddypress-trac noreply at wordpress.org
Thu Mar 6 20:04:10 UTC 2014

#5440: Add pagination to group membership requests admin page
 Reporter:  dcavins                  |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  2.0
Component:  Groups                   |     Version:  1.9.2
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |
Changes (by boonebgorges):

 * keywords:  has-patch => has-patch needs-refresh
 * milestone:  Awaiting Review => 2.0


 Thanks, dcavins!

 As you can see, I've begin the preliminary work on this. I've left the
 front-end implementation out for the moment. 5440.02 is the uncommitted
 parts of your patch.

 It looks like you've tried to emulate the Invites loop by throwing around
 a $group_id global. Can you please revert these changes and keep things
 the way that they were? To be honest, neither of the techniques is very
 good, but I would like to change as few things as necessary here. We can
 worry about the inconsistency later.

 I see that in your original patch you noticed that it was necessary to
 have the 'id' column from the bp_group_members table. However, your
 suggested fix - which involved changing the key to
 'group_members_table_id' to avoid conflicts - isn't the best strategy, as
 it'll break plugins that are directly accessing the global value here.
 Could you make the necessary changes in the template functions as well?

 Finally, can you please be certain (as you did in the case of invites)
 that these changes don't break existing themes (or at least bp-default)?


Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5440#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list