[buddypress-trac] [BuddyPress Trac] #5374: Administation screen to manage signups

[buddypress-trac]

#5374: Administation screen to manage signups
-------------------------------------------------+------------------
 Reporter:  imath                                |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  high                                 |   Milestone:  2.0
Component:  Members                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  2nd-opinion has-patch needs-testing  |
-------------------------------------------------+------------------

Comment (by imath):

 Replying to [comment:18 DJPaul]:
 > I have reviewed some of the patch:
 Thanks a lot.
 > * In the changes to`bp_update_to_2_0()`, why do we need to strip
 whitespace from `$user_login`? Is this something WPMU does when adding to
 the `signups` table?

 Yes see function wpmu_validate_user_signup() :
 https://core.trac.wordpress.org/browser/trunk/src/wp-includes/ms-
 functions.php#L472

 > * `delete_user_option( $signup->ID, 'capabilities' );` -- this looks
 dangerous. Is this really the best way just to hide this user from the
 regular user list until the account is activated? What happens if an admin
 edits a user's WP profile before the user activates their account? I think
 would WP re-build these options.

 Actually, each BuddyPress members on a multisite config is by default
 created this way, see {{{wpmu_create_user()}}} :
 https://core.trac.wordpress.org/browser/trunk/src/wp-includes/ms-
 functions.php#L1096
 I think it's on the contrary a good way to avoid some "troubles". As
 today, when a user registers on a non multisite config, he's a user so he
 can easily be edited (changing password, email and all) by the admin.
 Using this, the user won't be listed, the users count will be consistent
 and the user won't be in pending accounts and in users list at the same
 time.
 To edit the user, the admin must go into his MySql software, get the id
 and open it in the {{{user-edit.php}}} page. What happens in this case:
 the role select box displays, just as it's the case in multisite config :
 "No role for this site".
 I've tested updating the user: it doesn't change his user_status (remains
 to 2) and when the user activate his account, it works fine.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5374#comment:19>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac