[buddypress-trac] [BuddyPress Trac] #5727: Unit Tests: unset globals when using friends_add_friend() in setUp()

[buddypress-trac]

#5727: Unit Tests: unset globals when using friends_add_friend() in setUp()
--------------------------+---------------------
 Reporter:  DJPaul        |       Owner:  djpaul
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  2.1
Component:  Unit Tests    |     Version:
 Severity:  normal        |  Resolution:  fixed
 Keywords:                |
--------------------------+---------------------
Changes (by djpaul):

 * owner:   => djpaul
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"8555"]:
 {{{
 #!CommitTicketReference repository="" revision="8555"
 Tests: stop manually resetting `$bp->avatar` between tests.

 This causes tests to fail if those tests call `friends_add_friend()`
 inside `setUp()`
 as the `$bp->avatar->show_avatars` property is unset. Instead, rather than
 manually
 resetting the variable, we'll let `bp_core_set_avatar_globals()`, via
 `bp_setup_globals`
 in `assertPreConditions()`, reset it correctly.

 Fixes #5727
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5727#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac