[buddypress-trac] [BuddyPress Trac] #5720: bp_core_new_subnav_item() only barely works for non-user nav

[buddypress-trac]

#5720: bp_core_new_subnav_item() only barely works for non-user nav
--------------------------+------------------
 Reporter:  boonebgorges  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  2.1
Component:  Core          |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  dev-feedback  |
--------------------------+------------------

Comment (by boonebgorges):

 After looking at this for a while, I think the best way forward is to add
 a new argument to `bp_core_new_subnav_item()`: `no_access_url`, which, if
 present, will be used to perform the redirect. See 5720.patch, which
 implements this new argument, and reorganizes the logic that tries to
 determine the redirect URL for user pages so that it makes a bit more
 sense.

 Back in #4785, my proposal will then be to pass the following argument
 when calling `bp_core_new_subnav_item()` in `BP_Group_Extension`:

 {{{
     'no_access_url' => bp_get_group_permalink( groups_get_current_group()
 ),
 }}}

 (It's a bit hard to supply a separate patch for this, as it overlaps with
 some other changes, but the logic should be easy enough to see.)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5720#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac