[buddypress-trac] [BuddyPress Trac] #5720: bp_core_new_subnav_item() only barely works for non-user nav

[buddypress-trac]

#5720: bp_core_new_subnav_item() only barely works for non-user nav
--------------------------+-----------------
 Reporter:  boonebgorges  |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  2.1
Component:  Core          |    Version:
 Severity:  normal        |   Keywords:
--------------------------+-----------------
 `bp_core_new_subnav_item()` is designed for use with the individual member
 nav (see the references to 'displayed_user' throughout). Yet we use it in
 `BP_Group_Extension` to add group navigation items. This works fine for
 normal cases. But when you get into situations where you're doing funny
 things with redirects and user_has_access, things break. (See #4785 for
 some background.)

 For the moment, I'm going to use this ticket as a collection place for
 writing unit tests for this and related functions. Then I may start
 breaking them into smaller bits, so that we can make the API more
 predictable and consistent across components.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5720>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac