[buddypress-trac] [BuddyPress Trac] #4785: Decouple "visibility" and "access" properties

[buddypress-trac]

#4785: Decouple "visibility" and "access" properties
-------------------------+------------------
 Reporter:  smninja      |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  2.1
Component:  Groups       |     Version:  1.7
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+------------------

Comment (by boonebgorges):

 > So, are you thinking that if a plugin wants to mix and match settings
 based on group visibility ... should manage that by overriding
 user_can_visit() and user_can_see_nav_item()?

 Yes. I'd originally written the patch with the group status settings, as
 you'd originally suggested. But it made it pretty complex to register a
 simple group extension. So I got to thinking about how often this would
 actually happen, and I guess I figured that in those relatively rare
 cases, it makes sense for plugin authors to write the logic themselves,
 rather than overcomplicating the API for the majority of users.

 dcavins - Did you have a look at the example extensions in bp4785.php?
 They're maybe of the most interest to someone like you who's writing
 plugins. I want to have a sense if the new way of registering access
 settings makes sense to someone building extensions.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4785#comment:24>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac