[buddypress-trac] [BuddyPress Trac] #5708: Broken Travis CI PHP 5.2 tests and improved Travis CI performance
buddypress-trac
noreply at wordpress.org
Fri Jun 13 23:33:41 UTC 2014
#5708: Broken Travis CI PHP 5.2 tests and improved Travis CI performance
--------------------------+------------------
Reporter: netweb | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.1
Component: Core | Version:
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+------------------
Comment (by netweb):
Replying to [comment:5 DJPaul]:
> My concern is that I'd prefer to know our tests are 100% passing before
we introduce changes to the test config, in case those changes break
something accidentally. We'd see straightaway the regression, where if we
commit the change when we know our tests are already broken, we'd be
unaware for much longer.
Could split the patch in two, the changes in `define-constants.php` would
get PHP 5.2 working now.
Testing the `define-constants.php` patch now against r8059 with no changes
in `.travis.yml` appears to get the PHP 5.2 tests running now.
https://travis-ci.org/ntwb/BuddyPress/builds/27538625
https://travis-ci.org/buddypress/BuddyPress/builds/27528336
My suggestion thus would be commit the changes in `define-constants.php`
now and `.travis.yml` later once BP's PHPUnit are passing.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5708#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list