[buddypress-trac] [BuddyPress Trac] #5701: like_escape() is deprecated as of WP 4.0

[buddypress-trac]

#5701: like_escape() is deprecated as of WP 4.0
--------------------------+-----------------
 Reporter:  boonebgorges  |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  2.1
Component:  Core          |    Version:
 Severity:  normal        |   Keywords:
--------------------------+-----------------
 See https://core.trac.wordpress.org/ticket/10041 and
 https://core.trac.wordpress.org/changeset/28711

 It's causing our Travis CI trunk builds to due due to unexpected
 deprecated notices: https://travis-
 ci.org/buddypress/BuddyPress/builds/27215588

 For the moment, I'm going to mark these tests with expectedDeprecated, so
 we can get our build passing again.

 For 2.1, we should have a proper solution. Given that the function is
 deprecated *and* its replacement is introduced in 4.0, we can't just swap
 it out (and still support earlier versions of WP). So either:

 1. We do nothing and just live with the deprecated notices, at least until
 we drop support for WP < 4.0
 2. We create a wrapper function `bp_esc_like()` that does the necessary
 check

 As much as I find the latter option unpleasant, I think it's probably the
 right way to go. Feedback welcome.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5701>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac