[buddypress-trac] [BuddyPress Trac] #5693: bp_profile_visibility_radio_buttons() misses id in label

buddypress-trac noreply at wordpress.org
Mon Jun 9 15:10:39 UTC 2014


#5693: bp_profile_visibility_radio_buttons() misses id in label
--------------------------+------------------------------
 Reporter:  SGr33n        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  XProfile      |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+------------------------------
Changes (by boonebgorges):

 * keywords:  needs-refresh =>
 * component:  Core => XProfile


Comment:

 SGr33n - Thanks very much for the properly formatted patch!

 The missing `echo` appears to be a bug that was introduced in r8210, and
 thus is a regression in BP 2.0. I'm going to put this ticket into 2.0.2
 for that reason.

 Your request to add classes to the `<li>` elements seems fine to me, but
 should go into the 2.1 milestone instead. Would you mind opening a
 separate ticket that explains the justification for this enhancement, and
 post a new patch there? Thanks!

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5693#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list