[buddypress-trac] [BuddyPress Trac] #5693: bp_profile_visibility_radio_buttons() misses id in label

buddypress-trac noreply at wordpress.org
Sat Jun 7 13:17:25 UTC 2014


#5693: bp_profile_visibility_radio_buttons() misses id in label
--------------------------+------------------------------
 Reporter:  SGr33n        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Core          |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------------

Comment (by SGr33n):

 The second patch also adds classes for radio buttons li containers, in
 order to make it possible to style them e.g. with an icon.

 Before:


 {{{
 <ul class="radio">
         <li>
                 <label for="see-field_2_public">
                         <input id="see-field_2_public" type="radio"
 checked="checked" value="public" name="field_2_visibility">
                         <span class="field-visibility-
 text">Chiunque</span>
                 </label>
         </li>
         <li>
                 <label for="see-field_2_adminsonly">
                         <input id="see-field_2_adminsonly" type="radio"
 value="adminsonly" name="field_2_visibility">
                         <span class="field-visibility-text">Solo io</span>
                 </label>
         </li>
 </ul>
 }}}

 Patch applied:


 {{{
 <ul class="radio">
         <li class="public">
                 <label for="see-field_2_public">
                         <input id="see-field_2_public" type="radio"
 checked="checked" value="public" name="field_2_visibility">
                         <span class="field-visibility-
 text">Chiunque</span>
                 </label>
         </li>
         <li class="adminsonly">
                 <label for="see-field_2_adminsonly">
                         <input id="see-field_2_adminsonly" type="radio"
 value="adminsonly" name="field_2_visibility">
                         <span class="field-visibility-text">Solo io</span>
                 </label>
         </li>
 </ul>
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5693#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list