[buddypress-trac] [BuddyPress Trac] #5327: bp_get_the_thread_recipients() is not displaying correctly

[buddypress-trac]

#5327: bp_get_the_thread_recipients() is not displaying correctly
----------------------------------------+--------------------
 Reporter:  colabsadmin                 |       Owner:
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  2.1
Component:  Messaging                   |     Version:  1.9.1
 Severity:  normal                      |  Resolution:
 Keywords:  needs-patch good-first-bug  |
----------------------------------------+--------------------
Changes (by DJPaul):

 * keywords:  needs-patch => needs-patch good-first-bug


Comment:

 To fix this, I suggest the following:

 * Remove the `< 5` handling from `bp_get_the_thread_recipients()`.
 * Re-add that code around the second call to
 `bp_get_the_thread_recipients()` in `bp-templates/bp-
 legacy/buddypress/members/single/messages/single.php`.
  * Adjust the code you're adding to fix the localisation bug with the "%d
 Recipients" string; it should be using `%s` and `number_format_i18n()`.
  * "Recipients" probably should be lower-cased.

 I suggest moving the `< 5` checks into the template because this feels
 like something a theme would want to control, rather than have to handle a
 hardcoded limit in BuddyPress core.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5327#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac