[buddypress-trac] [BuddyPress Trac] #5652: root_blog_id problem since trunk has been "gruntified" for website using trunk version
buddypress-trac
noreply at wordpress.org
Wed Jul 30 20:40:27 UTC 2014
#5652: root_blog_id problem since trunk has been "gruntified" for website using
trunk version
------------------------------------+---------------------
Reporter: imath | Owner: DJPaul
Type: defect (bug) | Status: closed
Priority: high | Milestone: 2.1
Component: Core | Version: 2.0
Severity: normal | Resolution: fixed
Keywords: has-patch dev-feedback |
------------------------------------+---------------------
Changes (by r-a-y):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"8740"]:
{{{
#!CommitTicketReference repository="" revision="8740"
Streamline internal path and plugin directory properties.
Due to the introduction of Grunt (#5160), a few issues have popped up with
BP's internal properties (file, basename, plugin_dir, and plugin_url)
being
incorrect for those running trunk.
To address this:
In the stub `bp-loader.php` file:
- We introduce a new constant - `BP_SOURCE_DIRECTORY` - to determine what
source folder is being run from trunk.
- `BP_PLUGIN_DIR` and `BP_PLUGIN_URL` are defined so these constants take
precedence over the ones in the main bp-loader.php file.
- `BP_PLUGIN_URL` uses a slightly different algorithm to be nice to
symlinked directories as `plugin_dir_url()` does not work properly in
these instances.
In the main `bp-loader.php file:
- `BP_SOURCE_DIRECTORY` is set to a blank string.
- The `file` and `basename` are calculated based off the `BP_PLUGIN_DIR`
constant
- `plugin_dir` and `plugin_url` are set to whatever build is running
Fixes #5652.
}}}
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5652#comment:23>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list