[buddypress-trac] [BuddyPress Trac] #3278: @mentions autosuggest support

buddypress-trac noreply at wordpress.org
Sat Jul 26 19:46:24 UTC 2014


#3278: @mentions autosuggest support
------------------------------------+-----------------------
 Reporter:  DJPaul                  |       Owner:
     Type:  enhancement             |      Status:  assigned
 Priority:  normal                  |   Milestone:  2.1
Component:  Notifications           |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+-----------------------

Comment (by r-a-y):

 Love it, DJPaul!

 Some tiny, tiny things:

 * In `bp_activity_mentions_script()`, can we break out the following logic
 to a filterable function so it can be potentially hooked by plugins?

 {{{
 if ( ! bp_activity_do_mentions() || ! bp_is_user_active() || ! (
 bp_is_activity_component() || bp_is_blog_page() && is_singular() &&
 comments_open() ) )
 }}}

 Other than that, looks solid!


 * In `mentions.js`, for the `'suffix'`, can we add a space?  This is to
 emulate Twitter and Github.
 * For consistency, can we change the red text colour to the blue that we
 use when the `#whats-new textarea` is in focus or a similar hue to that?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3278#comment:42>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list