[buddypress-trac] [BuddyPress Trac] #5781: strtotime() is evil don't use it

buddypress-trac noreply at wordpress.org
Sat Jul 26 19:00:15 UTC 2014


#5781: strtotime() is evil don't use it
--------------------------+-----------------------
 Reporter:  r-a-y         |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  2.1
Component:  Core          |    Version:
 Severity:  normal        |   Keywords:  has-patch
--------------------------+-----------------------
 In reference to r8692, `bp_core_time_since()` is used in conjunction with
 `strtotime()`.

 `strotime()` is unnecessary since we use `gmmktime()` in
 `bp_core_time_since()`.  See line 795:
 https://buddypress.trac.wordpress.org/browser/tags/2.0.1/bp-core/bp-core-
 functions.php#L792

 Attached patch removes the `strtotime()` function from r8692.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5781>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list