[buddypress-trac] [BuddyPress Trac] #4310: Members Profile Shows "active sometime ago"

[buddypress-trac]

#4310: Members Profile Shows "active sometime ago"
------------------------------+---------------------
 Reporter:  frank13           |       Owner:  DJPaul
     Type:  enhancement       |      Status:  closed
 Priority:  normal            |   Milestone:  2.1
Component:  Core              |     Version:  1.5.6
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |
------------------------------+---------------------
Changes (by r-a-y):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"8676"]:
 {{{
 #!CommitTicketReference repository="" revision="8676"
 Fix issues with bp_core_time_since().

 Previously, when the $newer_date parameter isn't passed, we generated a
 UNIX timestamp using strtotime() and bp_core_current_time().  strtotime()
 uses the default timezone, which can cause timezone discrepencies if the
 server time is not UTC.

 This commit removes the strtotime() usage and refactors
 bp_core_current_time()
 to accept current_time()'s 'type' parameter.  This allows us to correctly
 grab the UTC timestamp when setting bp_core_current_time()'s second
 argument to 'timestamp'.

 Commit also adds some unit tests.

 Fixes #4310.
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4310#comment:38>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac