[buddypress-trac] [BuddyPress Trac] #5749: bp_blogs_record_existing_blogs() improvements

[buddypress-trac]

#5749: bp_blogs_record_existing_blogs() improvements
-----------------------------+------------------
 Reporter:  johnjamesjacoby  |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  2.1
Component:  Blogs            |     Version:
 Severity:  normal           |  Resolution:
 Keywords:                   |
-----------------------------+------------------

Comment (by johnjamesjacoby):

 In [changeset:"8598"]:
 {{{
 #!CommitTicketReference repository="" revision="8598"
 Clean up `bp_blogs_add_user_to_blog()`:

 * Compare user roles against `get_editable_roles()` so dynamic roles
 cannot be accidentally used.
 * Use `array_shift()` rather than `array_search()` to speed up comparison.
 * Add brackets and inline doc.

 See #5749.
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5749#comment:12>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac