[buddypress-trac] [BuddyPress Trac] #5390: Remove some old BuddyBar stuff

[buddypress-trac]

#5390: Remove some old BuddyBar stuff
------------------------------+------------------
 Reporter:  DJPaul            |       Owner:
     Type:  task              |      Status:  new
 Priority:  normal            |   Milestone:  2.1
Component:  Toolbar/BuddyBar  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |
------------------------------+------------------

Comment (by boonebgorges):

 5390.02.patch does the following:

 - Moves BuddyBar functions, unmodified into deprecated/2.1.php
 - Instead of adding `_deprecated_function()` notices to every single one
 (resulting in a torrent of deprecated notices for sites using the
 BuddyBar), add a single `doing_it_wrong()` notice in
 `bp_core_load_admin_bar()` if BuddyBar is enabled
 - Leaves all the BuddyBar loading logic in place, but removes all the
 settings interface

 This way, sites using `BP_USE_WP_ADMIN_BAR=false` will continue to have
 the BuddyBar work seamlessly, but will see an error. Meanwhile, we get rid
 of lots of cruft in our main plugin files. Installations that have chosen
 to block the loading of deprecated functions (`BP_IGNORE_DEPRECATED`) will
 not load the functions at all. (Users who mistakenly have `define(
 'BP_USE_WP_ADMIN_BAR', false );` along with `define(
 'BP_IGNORE_DEPRECATED', true );` will have no toolbar at all, but the site
 will continue to load.)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5390#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac