[buddypress-trac] [BuddyPress Trac] #5103: Group slug and user's subnav parent_slug trouble

[buddypress-trac]

#5103: Group slug and user's subnav parent_slug trouble
-----------------------------------+-----------------------------
 Reporter:  imath                  |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  low                    |   Milestone:  Future Release
Component:  Core                   |     Version:
 Severity:  major                  |  Resolution:
 Keywords:  2nd-opinion has-patch  |
-----------------------------------+-----------------------------

Comment (by boonebgorges):

 imath, your patch makes my eyes burn :) I know that the problem you're
 trying to solve is an annoying one, but the fact remains that it's an edge
 case. And blocking the creation of nav items based on parent_url is likely
 to cause backward compatibility issues in cases where people are doing
 creative things building the nav items.

 I had to make a long drive yesterday after reading this patch, so had a
 chance to think a lot about option (b) :) I think that it'd  be possible
 to refactor some of this in the way I suggest *without* breaking backward
 compatibility too much, through the creative use of the `__get()` magic
 method and/or some by-reference markers where we're moving stuff around.
 Let me think about this a bit more and work up a proof of concept. I think
 it's doing this the right way if we're going to do it at all.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5103#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac