[buddypress-trac] [BuddyPress Trac] #5336: Add "manage invitations" pane to group admin screen

[buddypress-trac]

#5336: Add "manage invitations" pane to group admin screen
-----------------------------------------+--------------------
 Reporter:  dcavins                      |       Owner:
     Type:  enhancement                  |      Status:  new
 Priority:  normal                       |   Milestone:  2.0
Component:  Administration               |     Version:  1.9.1
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch reporter-feedback  |
-----------------------------------------+--------------------
Changes (by boonebgorges):

 * keywords:  has-patch => has-patch reporter-feedback


Comment:

 The nice thing about the `bp_group_has_membership_requests()` function is
 that it sets up the template loop, so you'll have access to the template
 functions as well as pagination. Is there a reason you don't want to use
 that?

 Related: we have a template loop for group invites too:
 `bp_group_has_invites()`. I see that you wrote your own database query to
 get outstanding group invites, though we already have a this template loop
 and `groups_get_invites_for_group()`. Is this just because you needed
 limits/pagination? All things being equal, I'd prefer to use the functions
 that we've already got, improving them as necessary, rather than creating
 new ones (especially in the case of one-off database query methods).

 What do you think?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5336#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac