[buddypress-trac] [BuddyPress Trac] #5323: In the "Pages" meta box of Menu Administration Screen, exclude Activate and Register pages

buddypress-trac noreply at wordpress.org
Sun Jan 19 16:45:17 UTC 2014


#5323: In the "Pages" meta box of Menu Administration Screen, exclude Activate and
Register pages
-----------------------------------+------------------------------
 Reporter:  imath                  |       Owner:
     Type:  enhancement            |      Status:  new
 Priority:  low                    |   Milestone:  Awaiting Review
Component:  Core                   |     Version:  1.9.1
 Severity:  minor                  |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+------------------------------

Comment (by DJPaul):

 Some feedback about the patch:

 * `$pages` should be initialised to an empty array.
 * The function would be approx. 117% better if it had phpDoc.
 * Minor code standards point: `!empty` should be `! empty`.

 Other than that, looks good.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5323#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list