[buddypress-trac] [BuddyPress] #5322: Some menu items don't work correctly

buddypress-trac noreply at wordpress.org
Sun Jan 5 18:49:14 UTC 2014


#5322: Some menu items don't work correctly
-----------------------------------------+------------------------------
 Reporter:  Zachary DuBois               |       Owner:
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  Awaiting Review
Component:  Core                         |     Version:  1.9.1
 Severity:  normal                       |  Resolution:
 Keywords:  reporter-feedback has-patch  |
-----------------------------------------+------------------------------
Changes (by imath):

 * keywords:  reporter-feedback => reporter-feedback has-patch


Comment:

 I was able to figure out what is going wrong with the 'Registration'
 BuddyPress user nav link thanks to the chat i had with the member of bp-
 fr.net website.

 If the post_name (in other words the slug) of the registration page is not
 'register', then we have a problem. The display of the registration link
 is managed in {{{bp_setup_nav_menu_item()}}} (bp-core-filters.php)
 The check looks for 'register' into the class name {{{bp-(.*)-nav}}}, so
 if the slug of the registration page is 'signup' the class is set to bp-
 signup-nav in {{{bp_nav_menu_get_loggedout_pages()}}} and the condition
 will never matched causing some mess (register link displayed to the
 logged in user instead of the logged out one).

 As in this part, the slug is only used to actually build the
 {{{bp-(.*)-nav}}}, i think the best is to do as for the login link : just
 use 'register' instead of the post_name (see 5322.01.diff attached to this
 ticket)

 This will fix the trouble for the registration link.

 @Zachary DuBois can you confirm 5322.01.diff is fixing your trouble with
 the registration link (PS : you'll need to first remove the registration
 link from the menu, to add it back)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5322#comment:8>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list