[buddypress-trac] [BuddyPress Trac] #5436: BP_Core shouldn't run on 'bp_setup_components'

[buddypress-trac]

#5436: BP_Core shouldn't run on 'bp_setup_components'
-----------------------------------+------------------
 Reporter:  r-a-y                  |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  2.0
Component:  Core                   |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+------------------

Comment (by boonebgorges):

 > Me thinks we could also add a parameter so we can run the
 setup_globals() method based on a custom priority. This would be like the
 'adminbar_myaccount_order' parameter in the component start() method. Does
 this sound like too much finagling?

 This sounds more like my suggestion 1 here
 https://buddypress.trac.wordpress.org/ticket/5436#comment:2 - enforcing a
 load order, rather than disentangling components. I'm not opposed to
 determining and enforcing the proper load order for other reasons, though
 FWIW I think it's not the most elegant workaround to the root problem of
 entanglement.

 > Actually, we will need 'populate_extras' to be true

 Ugh, I guess that's right. An alternative is to do two separate
 BP_Group_Member_Query queries: one with 'role' => array( 'admin' ) and the
 other with 'role' => array( 'mod' ). This is not very beautiful. Another
 option is to rethink what 'populate_extras' means. Maybe setting
 is_admin/is_mod should not be an optional component of calling up
 `BP_Group_Member_Query`. This seems more elegant, though it would add a
 very small amount of overhead in some cases.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5436#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac